LadyForest commented on code in PR #21554:
URL: https://github.com/apache/flink/pull/21554#discussion_r1057409885
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java:
##########
@@ -595,10 +596,16 @@ private Operation convertAlterTableOptions(
new CatalogPartitionImpl(newProps,
catalogPartition.getComment()));
} else {
// it's altering a table
- Map<String, String> newOptions = new
HashMap<>(oldTable.getOptions());
- newOptions.putAll(
-
OperationConverterUtils.extractProperties(alterTableOptions.getPropertyList()));
- return new AlterTableOptionsOperation(tableIdentifier,
oldTable.copy(newOptions));
+ Map<String, String> newOptions =
Review Comment:
Nit: the naming of `newOptions` and `allOptions` is a little confusing. What
about `changeOptions` and `newOptions`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
