fsk119 commented on code in PR #19329:
URL: https://github.com/apache/flink/pull/19329#discussion_r1058046923


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java:
##########
@@ -144,6 +147,163 @@ public static Operation convertChangeColumn(
         // TODO: handle watermark and constraints
     }
 
+    public static Operation convertRenameColumn(
+            ObjectIdentifier tableIdentifier,
+            String originColumnName,
+            String newColumnName,
+            CatalogTable originTable,
+            ResolvedSchema originResolveSchema) {
+        Schema originSchema = originTable.getUnresolvedSchema();

Review Comment:
   The current implementation also modify the pk list if the original column is 
in the list.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to