darenwkt commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-aws/pull/39#discussion_r1058982327
##########
flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/StreamConsumerRegistrar.java:
##########
@@ -77,8 +79,8 @@ public StreamConsumerRegistrar(
* @throws InterruptedException
*/
public String registerStreamConsumer(final String stream, final String
streamConsumerName)
- throws ExecutionException, InterruptedException {
- LOG.debug("Registering stream consumer - {}::{}", stream,
streamConsumerName);
+ throws Exception {
Review Comment:
I think we can generalise it here because previously ExecutionException,
InterruptedException were thrown from a CompletableFuture get method. However,
we are no longer using Future here as registerStreamConsumer is called
synchronously now (via Callable call method) instead of async. Unlike
CompletableFuture, Callable call method throws Exception instead of Execution +
InterruptedException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
