Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2562#discussion_r81857075
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/windowDsl.scala
 ---
    @@ -0,0 +1,90 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.scala.table
    +
    +import org.apache.flink.api.table.expressions.Expression
    +import org.apache.flink.api.table.{SessionWindow, SlideWithSize, 
TumblingWindow}
    +
    +/**
    +  * Helper object for creating a tumbling window. In a tumbling window 
elements are assigned to
    +  * fixed length, non-overlapping windows of a specified window size. For 
example, if you specify a
    +  * window size of 5 minutes, the following operation will get 5 minutes 
worth of elements in
    +  * each invocation.
    +  */
    +object Tumble {
    +
    +  /**
    +    * Creates a tumbling window. In a tumbling window elements are 
assigned to fixed length,
    +    * non-overlapping windows of a specified window size. For example, if 
you specify a window
    +    * size of 5 minutes, the following operation will get 5 minutes worth 
of elements in
    --- End diff --
    
    I think following operation is not well defined. How about "For example, if 
you specify a tumbling window of 5 minutes size, elements will be grouped in 5 
minute intervals."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to