[
https://issues.apache.org/jira/browse/FLINK-29634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653712#comment-17653712
]
Jiale Tan edited comment on FLINK-29634 at 1/3/23 12:50 AM:
------------------------------------------------------------
I see. [~gyfora] Thanks for the input. I checked pom files again and your
solution makes sense.
One more question - how can we deal with
{{io.fabric8.kubernetes.client.server.mock.*}} classes?
They are not a part of {{flink-kubernetes}}, but introduced
[here|https://github.com/apache/flink-kubernetes-operator/blob/a1842d4c0170feb008293963ec51c0343f42771d/flink-kubernetes-standalone/pom.xml#L74-L78],
so there are no shaded version for them.
I am running into issues
[here|https://github.com/apache/flink-kubernetes-operator/blob/7ced741f51a99f2093ce8a45c8c92879a247f836/flink-kubernetes-standalone/src/test/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClientTest.java#L58],
we are expecting an
{{org.apache.flink.kubernetes.shaded.io.fabric8.kubernetes.client.NamespacedKubernetesClient}}
object for {{kubernetesClient}} but the mockServer.createClient() will create
an {{io.fabric8.kubernetes.client.NamespacedKubernetesClient}}.
was (Author: JIRAUSER290356):
I see. [~gyfora] Thanks for the input. I checked pom files again and your
solution makes sense.
One more question - how can we deal with
{{io.fabric8.kubernetes.client.server.mock.*}} classes?
They are not a part of {{{}flink-kubernetes{}}}, but introduced
[here|https://github.com/apache/flink-kubernetes-operator/blob/a1842d4c0170feb008293963ec51c0343f42771d/flink-kubernetes-standalone/pom.xml#L74-L78],
so there are no shaded version for them.
We will run into issues like
[this|https://github.com/apache/flink-kubernetes-operator/blob/7ced741f51a99f2093ce8a45c8c92879a247f836/flink-kubernetes-standalone/src/test/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClientTest.java#L58],
we are expecting an
{{org.apache.flink.kubernetes.shaded.io.fabric8.kubernetes.client.NamespacedKubernetesClient}}
object for {{kubernetesClient}} but the mockServer.createClient() will create
an {{io.fabric8.kubernetes.client.NamespacedKubernetesClient}}.
> Support periodic checkpoint triggering
> --------------------------------------
>
> Key: FLINK-29634
> URL: https://issues.apache.org/jira/browse/FLINK-29634
> Project: Flink
> Issue Type: New Feature
> Components: Kubernetes Operator
> Reporter: Thomas Weise
> Assignee: Jiale Tan
> Priority: Major
>
> Similar to the support for periodic savepoints, the operator should support
> triggering periodic checkpoints to break the incremental checkpoint chain.
> Support for external triggering will come with 1.17:
> https://issues.apache.org/jira/browse/FLINK-27101
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
