LadyForest commented on code in PR #21577:
URL: https://github.com/apache/flink/pull/21577#discussion_r1060300795
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java:
##########
@@ -685,18 +731,18 @@ String getComment(SqlTableColumn column) {
//
--------------------------------------------------------------------------------------------
private void validateColumnName(
- String originColumnName,
+ String oldColumnName,
String newColumnName,
- ResolvedSchema originSchemas,
+ ResolvedSchema oldSchemas,
List<String> partitionKeys) {
validateColumnName(
- originColumnName,
- originSchemas,
+ oldColumnName,
+ oldSchemas,
Review Comment:
Nit: `oldSchemas` -> `oldSchema` ?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java:
##########
@@ -685,18 +731,18 @@ String getComment(SqlTableColumn column) {
//
--------------------------------------------------------------------------------------------
private void validateColumnName(
- String originColumnName,
+ String oldColumnName,
String newColumnName,
- ResolvedSchema originSchemas,
+ ResolvedSchema oldSchemas,
Review Comment:
Nit: `oldSchemas` -> `oldSchema` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
