XComp commented on code in PR #21467:
URL: https://github.com/apache/flink/pull/21467#discussion_r1060497575
##########
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatMonitorImpl.java:
##########
@@ -39,6 +39,8 @@
private static final Logger LOG =
LoggerFactory.getLogger(HeartbeatMonitorImpl.class);
+ public static final int FAILED_RPC_DETECTION_DISABLED = -1;
Review Comment:
hm, I'm not feeling comfortable with adding production code (which I
consider the default value to be) to the options definitions. The reason for
this change was that `flink-core` doesn't have access to `flink-runtime`,
wasn't it? Alternatively, we could move the `HeartbeatManagerOptions` into the
`flink-runtime` package. That would require us to add the package that contains
the options to
[ConfigurationOptionLocator](https://github.com/apache/flink/blob/6cce68dcdc1baf4be2a9e1549983d010644b5ee3/flink-docs/src/main/java/org/apache/flink/docs/util/ConfigurationOptionLocator.java).
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
