reta commented on code in PR #5:
URL:
https://github.com/apache/flink-connector-opensearch/pull/5#discussion_r1060946596
##########
flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchSinkITCase.java:
##########
@@ -146,29 +146,30 @@ private void runTest(
.setAllowInsecure(true)
.build();
- final StreamExecutionEnvironment env = new LocalStreamEnvironment();
- env.enableCheckpointing(100L);
- if (!allowRestarts) {
- env.setRestartStrategy(RestartStrategies.noRestart());
- }
- DataStream<Long> stream = env.fromSequence(1, 5);
+ try (final StreamExecutionEnvironment env = new
LocalStreamEnvironment()) {
Review Comment:
Not related by `StreamExecutionEnvironment` is `AutoCloseable`, slightly
changing the test case
##########
flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchSinkITCase.java:
##########
@@ -146,29 +146,30 @@ private void runTest(
.setAllowInsecure(true)
.build();
- final StreamExecutionEnvironment env = new LocalStreamEnvironment();
- env.enableCheckpointing(100L);
- if (!allowRestarts) {
- env.setRestartStrategy(RestartStrategies.noRestart());
- }
- DataStream<Long> stream = env.fromSequence(1, 5);
+ try (final StreamExecutionEnvironment env = new
LocalStreamEnvironment()) {
Review Comment:
Not related but `StreamExecutionEnvironment` is `AutoCloseable`, slightly
changing the test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
