gunnarmorling commented on code in PR #40:
URL: https://github.com/apache/flink-playgrounds/pull/40#discussion_r1061620379
##########
pyflink-walkthrough/payment_msg_proccessing.py:
##########
@@ -73,9 +74,9 @@ def log_processing():
t_env.register_function('province_id_to_name', province_id_to_name)
t_env.from_path("payment_msg") \
- .select("province_id_to_name(provinceId) as province, payAmount") \
- .group_by("province") \
- .select("province, sum(payAmount) as pay_amount") \
+ .select(call('province_id_to_name',
col('provinceId')).alias("province"), col('payAmount')) \
+ .group_by(col('province')) \
+ .select(col('province'), call('sum',
col('payAmount').alias("pay_amount"))) \
Review Comment:
That string syntax used before was deprecated and [removed in
1.16](https://issues.apache.org/jira/browse/FLINK-26986).
##########
pyflink-walkthrough/docker-compose.yml:
##########
@@ -47,6 +47,10 @@ services:
- JOB_MANAGER_RPC_ADDRESS=jobmanager
zookeeper:
image: wurstmeister/zookeeper:3.4.6
+ ulimits:
+ nofile:
+ soft: 65536
+ hard: 65536
Review Comment:
Without that, that (old) Zookeeper version won't start on current Docker
installations, which give unlimited file handles, causing the app to run out of
memory. Ideally, we'd use a more up-to-date Zookeeper version, but there's no
newer version of that Wurstmeister image, and I don't want to further expand
scope of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
