jiangxin369 commented on code in PR #193:
URL: https://github.com/apache/flink-ml/pull/193#discussion_r1062165249
##########
flink-ml-benchmark/src/test/java/org/apache/flink/ml/benchmark/BenchmarkTest.java:
##########
@@ -54,6 +60,44 @@ public void testParseJsonFile() throws Exception {
assertTrue(benchmarks.containsKey("KMeansModel-1"));
}
+ @Test
+ public void testJsonFileLegality() throws IOException,
ClassNotFoundException {
+ File resourcesDir =
+ new File(
+ this.getClass()
+ .getClassLoader()
+ .getResource("benchmark-demo.json")
+ .getPath())
+ .getParentFile();
+ File[] jsonFiles =
+ resourcesDir.listFiles(
+ (dir, name) ->
+ name.endsWith(".json") &&
!name.equals("benchmark-demo.json"));
Review Comment:
The `benchmark-demo.json` is not included because some cases in the file
like `Unmatch-Input` has invalid paramMap. It is by design which makes it
cannot be parsed correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
