lindong28 commented on code in PR #21579:
URL: https://github.com/apache/flink/pull/21579#discussion_r1062408302
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java:
##########
@@ -700,11 +752,20 @@ private <T> WatermarkGaugeExposingOutput<StreamRecord<T>>
createOutputCollector(
// If the chaining output does not copy we need to copy in the
broadcast output,
// otherwise multi-chaining would not work correctly.
if (containingTask.getExecutionConfig().isObjectReuseEnabled()) {
- return closer.register(new
CopyingBroadcastingOutputCollector<>(asArray));
+ result = closer.register(new
CopyingBroadcastingOutputCollector<>(asArray));
} else {
- return closer.register(new
BroadcastingOutputCollector<>(asArray));
+ result = closer.register(new
BroadcastingOutputCollector<>(asArray));
+ }
+ }
+
+ if (shouldAddMetric) {
Review Comment:
Thanks for the suggestion. I have updated the PR to explain it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
