beyond1920 commented on code in PR #21602:
URL: https://github.com/apache/flink/pull/21602#discussion_r1062420317
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserDMLHelper.java:
##########
@@ -316,7 +316,14 @@ public Operation
createInsertOperation(HiveParserCalcitePlanner analyzer, RelNod
topQB.getParseInfo().getInsertOverwriteTables().keySet().stream()
.map(String::toLowerCase)
.collect(Collectors.toSet())
- .contains(tableName);
+ .contains(tableName.toLowerCase());
+
+ boolean isInsertInto =
topQB.getParseInfo().isInsertIntoTable(tableName);
+
+ assert overwrite || isInsertInto
Review Comment:
use preconditions to check?
And use "Please report this bug." to reminder users to report this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
