jiangxin369 commented on code in PR #193:
URL: https://github.com/apache/flink-ml/pull/193#discussion_r1062495231
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/clustering/KMeansModelDataGenerator.java:
##########
@@ -55,20 +61,36 @@ public Table[] getData(StreamTableEnvironment tEnv) {
InputDataGenerator<?> vectorArrayGenerator = new
DenseVectorArrayGenerator();
ReadWriteUtils.updateExistingParams(vectorArrayGenerator, paramMap);
vectorArrayGenerator.setNumValues(1);
+ vectorArrayGenerator.setColNames(new String[] {"centroids"});
Review Comment:
Yes, it is necessary. Because there's a mistake in
`KmeansModelDataGenerator` which would break the test for `benchmark-demo.json`.
##########
flink-ml-benchmark/src/main/resources/minmaxscaler-benchmark.json:
##########
@@ -22,19 +22,15 @@
"vectorDim": 100,
"colNames": [
[
- "features"
+ "inputCol"
Review Comment:
Thanks for reminding, I verified all updated files and they work well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
