lindong28 commented on code in PR #197: URL: https://github.com/apache/flink-ml/pull/197#discussion_r1063496759
########## flink-ml-benchmark/src/main/resources/linearregression-benchmark.json: ########## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "version": 1, + "linearregression": { + "stage": { + "className": "org.apache.flink.ml.regression.linearregression.LinearRegression", + "paramMap": { + "featuresCol": "features", Review Comment: Strictly speaking, if a user expects to use the default value for a column parameter, he/she would not have to specify the column name, right? Could you come up with a use-case for explicitly specifying the default column name for those column parameters? It is typically useful to specify values for parameters that users are likely to tune (e.g. input data count). IMO it is unlikely users would care the column names used in a benchmark. Thus it seems simpler to skip them. What do you think? ########## flink-ml-benchmark/src/main/resources/linearregression-benchmark.json: ########## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "version": 1, + "linearregression": { + "stage": { + "className": "org.apache.flink.ml.regression.linearregression.LinearRegression", + "paramMap": { + "featuresCol": "features", Review Comment: Strictly speaking, if a user expects to use the default value for a column parameter, he/she would not have to specify the column name, right? Could you come up with a use-case for explicitly specifying the default column name for those column parameters? It is typically useful to specify values for parameters that users are likely to tune (e.g. input data count). IMO it is unlikely users would care the column names used in a benchmark. Thus it seems simpler to skip them. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
