fsk119 commented on code in PR #21597:
URL: https://github.com/apache/flink/pull/21597#discussion_r1064257149
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/Executor.java:
##########
@@ -42,54 +42,50 @@ public interface Executor {
* Open a new session by using the given session id.
*
* @param sessionId session identifier.
- * @return used session identifier to track the session.
* @throws SqlExecutionException if any error happen
*/
- String openSession(@Nullable String sessionId) throws
SqlExecutionException;
+ void openSession(@Nullable String sessionId) throws SqlExecutionException;
/**
* Close the resources of session for given session id.
*
- * @param sessionId session identifier
* @throws SqlExecutionException if any error happen
*/
- void closeSession(String sessionId) throws SqlExecutionException;
+ void closeSession() throws SqlExecutionException;
/**
* Returns a copy of {@link Map} of all session configurations that are
defined by the executor
* and the session.
*
- * <p>Both this method and {@link #getSessionConfig(String)} return the
same configuration set,
- * but different return type.
+ * <p>Both this method and {@link #getSessionConfig()} return the same
configuration set, but
+ * different return type.
*/
- Map<String, String> getSessionConfigMap(String sessionId) throws
SqlExecutionException;
Review Comment:
> Does this mean that each executor can only have one session?
Yes, you are right. Executor only works for one session in the new design.
The Gateway is designed for the multitenancy.
> why we need sessionId, we can just define an executorId instead?
I think session id is still useful. For example, SQL Client can convey the
user name/password with the current API. So I am prone to keep it unchanged and
prepare for the future authentication mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
