xintongsong commented on code in PR #21347:
URL: https://github.com/apache/flink/pull/21347#discussion_r1064320554
##########
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java:
##########
@@ -1756,6 +1756,9 @@ public final class ConfigConstants {
/** The user lib directory name. */
public static final String DEFAULT_FLINK_USR_LIB_DIR = "usrlib";
+ /** The initial client timeout when submitting the job. */
+ public static final String INITIAL_CLIENT_HEARTBEAT_TIMEOUT =
"initialClientHeartbeatTimeout";
Review Comment:
`ConfigConstants` is public api annotated with `@Public`. We should not add
this internal config key here.
I think it would be good enough to introduce the config key as a constant in
`JobGraph`.
##########
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java:
##########
@@ -206,4 +206,14 @@ default CompletableFuture<Set<AbstractID>>
listCompletedClusterDatasetIds() {
default CompletableFuture<Void> invalidateClusterDataset(AbstractID
clusterDatasetId) {
return CompletableFuture.completedFuture(null);
}
+
+ /**
+ * The client reports the heartbeat to the dispatcher for aliveness.
+ *
+ * @param jobId The jobId for the client and the job.
+ * @return
+ */
+ default CompletableFuture<Void> reportHeartbeat(JobID jobId, long
expiredTimestamp) {
+ return CompletableFuture.completedFuture(null);
Review Comment:
```suggestion
return FutureUtils.completedVoidFuture();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
