mbalassi commented on code in PR #21128:
URL: https://github.com/apache/flink/pull/21128#discussion_r1064623916
##########
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java:
##########
@@ -608,10 +615,15 @@ public boolean accept(File dir, String name) {
public static boolean verifyStringsInNamedLogFiles(
final String[] mustHave, final ApplicationId applicationId, final
String fileName) {
final List<String> mustHaveList = Arrays.asList(mustHave);
- final File cwd = new File("target",
YARN_CONFIGURATION.get(TEST_CLUSTER_NAME_KEY));
+ final File cwd =
+ new File(
+ GenericTestUtils.getTestDir(),
+ YARN_CONFIGURATION.get(TEST_CLUSTER_NAME_KEY));
if (!cwd.exists() || !cwd.isDirectory()) {
+ LOG.info("Directory doesn't exist: {}", cwd.getAbsolutePath());
Review Comment:
nit: I would debug log this
##########
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java:
##########
@@ -639,6 +651,7 @@ public boolean accept(File dir, String name) {
}
}
if
(foundSet.containsAll(mustHaveList)) {
+ LOG.info("Contains");
Review Comment:
nit: I would debug log this, also please add a better log message - what
contains what exactly? 😏
##########
flink-connectors/flink-connector-hbase-1.4/pom.xml:
##########
@@ -155,6 +155,14 @@ under the License.
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>ch.qos.reload4j</groupId>
Review Comment:
It is a shame that we can not do this in a centralized way, e.g. via
dependency management.
##########
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java:
##########
@@ -608,10 +615,15 @@ public boolean accept(File dir, String name) {
public static boolean verifyStringsInNamedLogFiles(
final String[] mustHave, final ApplicationId applicationId, final
String fileName) {
final List<String> mustHaveList = Arrays.asList(mustHave);
- final File cwd = new File("target",
YARN_CONFIGURATION.get(TEST_CLUSTER_NAME_KEY));
+ final File cwd =
+ new File(
+ GenericTestUtils.getTestDir(),
+ YARN_CONFIGURATION.get(TEST_CLUSTER_NAME_KEY));
if (!cwd.exists() || !cwd.isDirectory()) {
+ LOG.info("Directory doesn't exist: {}", cwd.getAbsolutePath());
return false;
}
+ LOG.info("Directory exist: {}", cwd.getAbsolutePath());
Review Comment:
nit: I would debug log this
##########
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java:
##########
@@ -649,6 +662,7 @@ public boolean accept(File dir, String name) {
+ " file: "
+ f.getAbsolutePath());
}
+ LOG.info("Not contains");
Review Comment:
nit: I would debug log this, also please add a better log message - what
contains what exactly? 😏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
