[ 
https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551361#comment-15551361
 ] 

ASF GitHub Bot commented on FLINK-4751:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2600#discussion_r82141826
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkFuture.java
 ---
    @@ -190,7 +191,16 @@ public R recover(Throwable failure) throws Throwable {
                                        return Futures.future(new Callable<R>() 
{
                                                @Override
                                                public R call() throws 
Exception {
    -                                                   return future.get();
    +                                                   try {
    +                                                           return 
future.get();
    +                                                   } catch 
(ExecutionException e) {
    +                                                           // unwrap the 
execution exception if it's not a throwable
    --- End diff --
    
    Did you mean `Error` instead of `Throwable`?


> Extend Flink's futures to support combining two futures
> -------------------------------------------------------
>
>                 Key: FLINK-4751
>                 URL: https://issues.apache.org/jira/browse/FLINK-4751
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> A useful feature for Flink's futures would be to allow combining two futures:
> {code}
> Future<A> a = ...
> Future<B> b = ...
> Future<C> c = a.thenCombineAsync(b, new BiFunction<A, B, C>() {...}, 
> executor);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to