yuchuanchen commented on code in PR #21563:
URL: https://github.com/apache/flink/pull/21563#discussion_r1065501206
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala:
##########
@@ -211,6 +211,29 @@ object FlinkStreamRuleSets {
ProjectWindowTableFunctionTransposeRule.INSTANCE
)
+ /** RuleSet about project, but with
PROJECT_FILTER_TRANSPOSE_WHOLE_EXPRESSIONS. */
+ val PROJECT_RULES_V2: RuleSet = RuleSets.ofList(
Review Comment:
PROJECT_FILTER_TRANSPOSE_WHOLE_EXPRESSIONS means push filter fields into
projection. We introduce PROJECT_RULES_V2 because we meet cyclic rule problem
when we change PROJECT_FILTER_TRANSPOSE to
PROJECT_FILTER_TRANSPOSE_WHOLE_EXPRESSIONS directly in PROJECT_RULES. We
finally fix this issue by using PROJECT_FILTER_TRANSPOSE_WHOLE_EXPRESSIONS in
project_rewrite and PROJECT_FILTER_TRANSPOSE in logical rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
