lsyldliu commented on code in PR #21608:
URL: https://github.com/apache/flink/pull/21608#discussion_r1067164508


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/module/hive/HiveModule.java:
##########
@@ -81,6 +82,18 @@ public class HiveModule implements Module {
                                     "tumble_rowtime",
                                     "tumble_start")));
 
+    static final Set<String> FLINK_BUILT_IN_FUNC_FOR_HIVE =

Review Comment:
   In [FLINK-30579](https://github.com/apache/flink/pull/21629) pr, we will 
introduce an option to enable native hive sum aggregate function, so I think 
this set should only contain the agg function name, and exclude other functions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to