Myasuka commented on code in PR #21656:
URL: https://github.com/apache/flink/pull/21656#discussion_r1068037154
##########
flink-runtime-web/web-dashboard/src/app/components/humanize-watermark.pipe.ts:
##########
@@ -35,3 +35,19 @@ export class HumanizeWatermarkPipe implements PipeTransform {
}
}
}
+
+@Pipe({
+ name: 'humanizeWatermarkToDate',
+ standalone: true
+})
+export class HumanizeWatermarkToDatePipe implements PipeTransform {
+ constructor(private readonly configService: ConfigService) {}
+
+ public transform(value: number): number | string {
+ if (isNaN(value) || value <= this.configService.LONG_MIN_VALUE) {
+ return 'No Watermark (Watermarks are only available if EventTime is
used)';
Review Comment:
I think we already have the `No Watermark (Watermarks are only available if
EventTime is used)` descriptions in the original column, shall we just put a
`NA` or `-` here?
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/watermarks/job-overview-drawer-watermarks.component.html:
##########
@@ -31,8 +31,18 @@
>
<thead>
<tr>
- <th nzWidth="50%">SubTask</th>
- <th nzWidth="50%">Watermark</th>
+ <th nzWidth="33%">SubTask</th>
+ <th nzWidth="33%">Watermark</th>
+ <th nzWidth="34%">
+ Date of Watermark Timestamp
+ <i
+ class="header-icon"
+ nz-icon
+ nz-tooltip
+ nzTooltipTitle="This column shows the date that are parsed from
watermark timestamp with local time zone. Note that the time zone is obtained
through your browser. "
Review Comment:
```suggestion
nzTooltipTitle="This column shows the datetime that is parsed from
watermark timestamp with local time zone. Note that the time zone is obtained
through your browser. "
```
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/watermarks/job-overview-drawer-watermarks.component.html:
##########
@@ -31,8 +31,18 @@
>
<thead>
<tr>
- <th nzWidth="50%">SubTask</th>
- <th nzWidth="50%">Watermark</th>
+ <th nzWidth="33%">SubTask</th>
+ <th nzWidth="33%">Watermark</th>
+ <th nzWidth="34%">
+ Date of Watermark Timestamp
Review Comment:
```suggestion
Datetime of Watermark Timestamp
```
##########
flink-runtime-web/web-dashboard/src/app/components/humanize-watermark.pipe.ts:
##########
@@ -35,3 +35,19 @@ export class HumanizeWatermarkPipe implements PipeTransform {
}
}
}
+
+@Pipe({
+ name: 'humanizeWatermarkToDate',
Review Comment:
How about `humanizeWatermarkToDatetime` ?
##########
flink-runtime-web/web-dashboard/src/app/components/humanize-watermark.pipe.ts:
##########
@@ -35,3 +35,19 @@ export class HumanizeWatermarkPipe implements PipeTransform {
}
}
}
+
+@Pipe({
+ name: 'humanizeWatermarkToDate',
+ standalone: true
+})
+export class HumanizeWatermarkToDatePipe implements PipeTransform {
Review Comment:
Same here, maybe `HumanizeWatermarkToDatetimePipe` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
