XComp commented on PR #21630: URL: https://github.com/apache/flink/pull/21630#issuecomment-1380258947
Sorry for being picky on that one. But even with knowing these details, it becomes kind of hard for me to review this PR. There are still code location where I have questions but which are hard to mention in this PR if they are actually not touched as code change. Why do we need to do the cleanup before the refactoring? Can't we wait for the refactoring and clean up everything properly afterwards? Or do we gain anything from cleaning up code partially which I'm not aware of? Alternatively, if you really want to push for it, it might be more reasonable to ask @JingsongLi for a review or someone more related to whether the partial cleanup is to his liking. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
