Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2583#discussion_r82174054
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointMetaData.java
---
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.checkpoint;
+
+import org.apache.flink.util.Preconditions;
+
+import java.io.Serializable;
+
+/**
+ * Encapsulates all the meta data for a checkpoint.
+ */
+public class CheckpointMetaData implements Serializable {
+
+ private static final long serialVersionUID = -2387652345781312442L;
+
+ /** The ID of the checkpoint */
+ private final long checkpointId;
+
+ /** The timestamp of the checkpoint */
+ private final long timestamp;
+
+ private final CheckpointMetrics metrics;
+
+ public CheckpointMetaData(long checkpointId, long timestamp) {
+ this.checkpointId = checkpointId;
+ this.timestamp = timestamp;
+ this.metrics = new CheckpointMetrics();
+ }
+
+ public CheckpointMetaData(
+ long checkpointId,
+ long timestamp,
+ long synchronousDurationMillis,
+ long asynchronousDurationMillis,
+ long bytesBufferedInAlignment,
+ long alignmentDurationNanos) {
+ this.checkpointId = checkpointId;
+ this.timestamp = timestamp;
+ this.metrics = new CheckpointMetrics(
+ bytesBufferedInAlignment,
+ alignmentDurationNanos,
+ synchronousDurationMillis,
+ asynchronousDurationMillis);
+ }
+
+ public CheckpointMetrics getMetrics() {
+ return metrics;
+ }
+
+ public CheckpointMetaData setBytesBufferedInAlignment(long
bytesBufferedInAlignment) {
--- End diff --
I think the separation is fine, those places that need to update on metrics
typically to so in bulk and can just get a metrics object once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
