lincoln-lil commented on code in PR #21662:
URL: https://github.com/apache/flink/pull/21662#discussion_r1069021755
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Explainable.java:
##########
@@ -36,7 +36,20 @@
* e.g. estimated cost, changelog mode for streaming
* @return AST and the execution plan.
*/
- String explain(ExplainDetail... extraDetails);
+ default String explain(ExplainDetail... extraDetails) {
+ return explain(ExplainFormat.TEXT, extraDetails);
+ }
+
+ /**
+ * Returns the AST of this object and the execution plan to compute the
result of the given
+ * statement.
+ *
+ * @param format The output format of explain plan
Review Comment:
nit: explained
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##########
@@ -970,7 +970,21 @@ void createTemporarySystemFunction(
* estimated cost, changelog mode for streaming, displaying execution
plan in json format
* @return AST and the execution plan.
*/
- String explainSql(String statement, ExplainDetail... extraDetails);
+ default String explainSql(String statement, ExplainDetail... extraDetails)
{
+ return explainSql(statement, ExplainFormat.TEXT, extraDetails);
+ }
+
+ /**
+ * Returns the AST of the specified statement and the execution plan to
compute the result of
+ * the given statement.
+ *
+ * @param statement The statement for which the AST and execution plan
will be returned.
+ * @param format The output format of explain plan.
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
