gunnarmorling commented on PR #21532: URL: https://github.com/apache/flink/pull/21532#issuecomment-1382021282
Yeah, fair question; I'm not sure how useful that recursive cleaning approach is to begin with, it seems rather unlikely to encounter anonymous classes deeper in an object tree. `ClosureCleanerLevel.TOP_LEVEL` might be the more practical default behavior in that light. Other than that, traversing into _any_ JDK class probably shouldn't be attempted; arguably, it's a programming failure of the author of any serializable class if they allow for anonymous values in their fields. I'd say though let's not get the perfect into the way of the good. As you say, this change unlocks a number of usages, so it's an improvement over the status quo. Happy to log a follow-up issue to discuss further along the lines above. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
