zentol commented on code in PR #118:
URL: https://github.com/apache/flink-shaded/pull/118#discussion_r1069621107
##########
flink-shaded-netty-4/pom.xml:
##########
@@ -94,12 +94,12 @@ under the License.
<echo message="renaming native epoll library"
/>
<move
todir="${project.build.directory}/unpacked/META-INF/native"
includeemptydirs="false">
<fileset
dir="${project.build.directory}/unpacked/META-INF/native"/>
- <mapper type="glob"
from="libnetty_transport_native_epoll_x86_64.so"
to="liborg_apache_flink_shaded_netty4_netty_transport_native_epoll_x86_64.so"/>
+ <mapper type="glob"
from="libnetty_transport_native_epoll_*.so"
to="liborg_apache_flink_shaded_netty4_netty_transport_native_epoll_*.so"/>
</move>
<echo message="renaming native kqueue library"
/>
<move
todir="${project.build.directory}/unpacked/META-INF/native"
includeemptydirs="false">
<fileset
dir="${project.build.directory}/unpacked/META-INF/native"/>
- <mapper type="glob"
from="libnetty_transport_native_kqueue_x86_64.jnilib"
to="liborg_apache_flink_shaded_netty4_netty_transport_native_kqueue_x86_64.jnilib"/>
+ <mapper type="glob"
from="libnetty_transport_native_kqueue_*.jnilib"
to="liborg_apache_flink_shaded_netty4_netty_transport_native_kqueue_*.jnilib"/>
Review Comment:
Not sure if there is other stuff in the native directory that we wouldnt
want relocated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
