fsk119 commented on code in PR #21640:
URL: https://github.com/apache/flink/pull/21640#discussion_r1070212463
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/AddPartitionsOperation.java:
##########
@@ -38,7 +38,7 @@ public AddPartitionsOperation(
boolean ifNotExists,
List<CatalogPartitionSpec> partitionSpecs,
List<CatalogPartition> catalogPartitions) {
- super(tableIdentifier);
+ super(tableIdentifier, false);
Review Comment:
It's a little confusing for others to understand. `AddPartitionsOperation`
has `ifNotExists` and `ignoreIfNotExists` methods. Can we rename the
`ignoreIfNotExists` to `ignoreIfTableNotExists` here and `ifNotExists` to
`ignoreifPartitionNotExists`?
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterTable.java:
##########
@@ -49,16 +49,26 @@ public abstract class SqlAlterTable extends SqlCall {
protected final SqlIdentifier tableIdentifier;
protected final SqlNodeList partitionSpec;
+ protected final boolean ifExists;
Review Comment:
I think it's better to use `ifTableExists` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
