luoyuxia commented on code in PR #21658: URL: https://github.com/apache/flink/pull/21658#discussion_r1070239948
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsRowLevelModificationScan.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.connector.source.abilities; + +import org.apache.flink.table.connector.RowLevelModificationScanContext; +import org.apache.flink.table.connector.source.ScanTableSource; + +import javax.annotation.Nullable; + +/** + * Enables to tell the {@link ScanTableSource} the type of row-level modification the table source + * scan is for, and return {@link RowLevelModificationScanContext} which will then be passed to the + * sink which implements {@link SupportsRowLevelUpdate} or {@link SupportsRowLevelDelete}. It allows + * the table source to pass information to the table sink which is to be updated/deleted. Review Comment: I think we may need to highlight information is passed to the table sink that is to be updated/deleted. ########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsRowLevelModificationScan.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.connector.source.abilities; + +import org.apache.flink.table.connector.RowLevelModificationScanContext; +import org.apache.flink.table.connector.source.ScanTableSource; + +import javax.annotation.Nullable; + +/** + * Enables to tell the {@link ScanTableSource} the type of row-level modification the table source + * scan is for, and return {@link RowLevelModificationScanContext} which will then be passed to the + * sink which implements {@link SupportsRowLevelUpdate} or {@link SupportsRowLevelDelete}. It allows + * the table source to pass information to the table sink which is to be updated/deleted. + * + * <p>Note: This interface is optional for table source to support update/delete existing data. For + * the case that the table source won't need to know the type of row-level modification or pass + * information to sink, the table source doesn't need to implement it. + * + * <p>Note: Only if the {@link ScanTableSource} implements this interface, and the table is to be + * scanned to update/delete a table, the method {@link #applyRowLevelModificationScan} for the Review Comment: I change to ` The method {@link #applyRowLevelModificationScan} of the corresponding table source will be involved only if the {@link ScanTableSource} implements this interface and the table is to be scanned to update/delete existing data in a table ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
