fsk119 commented on code in PR #21562:
URL: https://github.com/apache/flink/pull/21562#discussion_r1070499711
##########
flink-table/flink-sql-client/pom.xml:
##########
@@ -58,6 +58,12 @@ under the License.
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
Review Comment:
It should be provided.
##########
flink-table/flink-sql-client/bin/sql-client.sh:
##########
@@ -67,6 +67,14 @@ if [[ ! "$CC_CLASSPATH" =~ .*flink-python.*.jar ]]; then
fi
fi
+# add flink-sql-gateway jar to the classpath
+if [[ ! "$CC_CLASSPATH" =~ .*flink-sql-gateway.*.jar ]]; then
+ FLINK_SQLGATEWAY_JAR=$(find "$FLINK_OPT_DIR" -regex
".*flink-sql-gateway.*.jar")
Review Comment:
We use FLINK_SQL_CLIENT_JAR here. I think it's nice we can align with the
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
