thexiay commented on code in PR #21676:
URL: https://github.com/apache/flink/pull/21676#discussion_r1070972564
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -1400,6 +1411,23 @@ public TableResultInternal executeInternal(Operation
operation) {
} catch (Exception e) {
throw new TableException("Failed to execute ANALYZE TABLE
command", e);
}
+ } else if (operation instanceof DeleteFromFilterOperation) {
+ if (isStreamingMode) {
+ throw new TableException("DELETE TABLE is not supported for
streaming mode now.");
+ }
+ Optional<Long> rows =
Review Comment:
This implement has some limit:
1. Predicate cannot contains subquery, it must be a deterministic
expressions.
2. This delete or update runtime execution is at client environment, maybe
it's network environment has a littele bit different from taskmanager in
cluster.(e.g. taskmanager can connect data source, but client cannot connect it
, so execute in here may fail)
Do you think those limitations are acceptable or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
