echauchot commented on PR #21636: URL: https://github.com/apache/flink/pull/21636#issuecomment-1384047261
> > No, see DefaultOperatorStateBackendBuilder I call AbstractStateBackend.getCompressionDecorator that reads execution.checkpointing.snapshot-compression conf parameter. > > Ah, sorry missed that :( That part looks good then. > > > Ok, adding the boolean will require to change the snapshot format indeed. This is why I have not added this boolean to avoid the format change. But, indeed, if a snapshot was compressed and the user then disables compression he could not read the previous compressed snapshot with my code. What about simply adding a compression boolean to operator state meta ? As a backward incompatible change, it requires a FLIP even if simple change, right ? > > Yes, I do think it requires a FLIP as it is a substantial change, but I believe this change is unavoidable if we want to add operator state compression. Ok, I'll write the FLIP and ping you on it for review, then when we agree on the architecture, I'll write the code and commit on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
