vahmed-hamdy commented on code in PR #42:
URL:
https://github.com/apache/flink-connector-aws/pull/42#discussion_r1071243445
##########
flink-connector-dynamodb/pom.xml:
##########
@@ -132,5 +132,12 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner-loader</artifactId>
Review Comment:
I am happy to follow this approach if we intend to have E2E tests, they need
not to be against an actual DDB (this is preferable ofc) but we need to verify
that the connector works when packaging the uber jar to sql client.
KDS tests for reference
https://github.com/apache/flink-connector-aws/blob/2a24e7c1e8d2a8f613838fd0419177d4f96991bf/flink-connector-aws-e2e-tests/flink-connector-aws-kinesis-streams-e2e-tests/pom.xml#L99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
