TanYuxin-tyx commented on code in PR #21612:
URL: https://github.com/apache/flink/pull/21612#discussion_r1071682166
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SsgNetworkMemoryCalculationUtils.java:
##########
@@ -93,28 +93,27 @@ public static void enrichNetworkMemory(
private static TaskInputsOutputsDescriptor
buildTaskInputsOutputsDescriptor(
ExecutionJobVertex ejv, Function<JobVertexID, ExecutionJobVertex>
ejvs) {
- Map<IntermediateDataSetID, Integer> maxInputChannelNums;
- Map<IntermediateDataSetID, Integer> maxSubpartitionNums;
+ Map<IntermediateDataSetID, Integer> maxInputChannelNums = new
HashMap<>();
Review Comment:
Thanks for helping reivew and Sorry about the late reply. @huwh
But the PR has been closed at
https://issues.apache.org/jira/browse/FLINK-30473.
I agree that your idea makes sense, but I think it is also not a serious
issue and may refactor it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]