fsk119 commented on code in PR #21665:
URL: https://github.com/apache/flink/pull/21665#discussion_r1071869134
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/CollectResultBase.java:
##########
@@ -29,23 +29,28 @@
/** A result that works through {@link TableResult#collect()}. */
public abstract class CollectResultBase implements DynamicResult {
- private final CloseableIterator<RowData> result;
+ private final CloseableIterator<RowData> resultIterator;
protected final Object resultLock;
protected AtomicReference<SqlExecutionException> executionException = new
AtomicReference<>();
protected final ResultRetrievalThread retrievalThread;
public CollectResultBase(TableResultInternal tableResult) {
- result = tableResult.collectInternal();
+ resultIterator = tableResult.collectInternal();
resultLock = new Object();
retrievalThread = new ResultRetrievalThread();
}
@Override
- public void close() throws Exception {
+ public void close() {
Review Comment:
Because all invokers ignore the errr, so I think it would much easier we
ignore this inside here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
