dannycranmer commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-aws/pull/39#discussion_r1072116820
##########
flink-connector-aws-base/pom.xml:
##########
@@ -52,6 +52,11 @@ under the License.
<artifactId>netty-nio-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>software.amazon.awssdk</groupId>
+ <artifactId>apache-client</artifactId>
+ </dependency>
Review Comment:
Yes, I already see it. For all connectors, thanks
##########
flink-connector-aws-base/pom.xml:
##########
@@ -52,6 +52,11 @@ under the License.
<artifactId>netty-nio-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>software.amazon.awssdk</groupId>
+ <artifactId>apache-client</artifactId>
+ </dependency>
Review Comment:
NOTICE files do not update automatically, so either:
- It is already included and this is not necessary, or
- The NOTICE files need updating
Since flink-connector-aws-base is common to all connectors we will need to
update all the NOTICE files I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
