lincoln-lil opened a new pull request, #21704:
URL: https://github.com/apache/flink/pull/21704
## What is the purpose of the change
Current `PushProjectIntoTableSourceScanRule` doesn't process the case
properly when no column is needed from source logically, it will generagte a
plan that selects nothing from a source (which supports projection push down) ,
this will not work with real connectors.
In this pr we will always choose the first (physical) column from the source
in such a case (Note that `LegacyTableSource` is not fixed since it is
deprecated so long)
## Brief change log
Fix PushProjectIntoTableSourceScanRule to always choose the first (physical)
column from the source when no column is needed from source logically
## Verifying this change
newly added countStar related cases in AggregateTestăAggregateITCase (both
streaming and batch modes covered)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
@Public(Evolving): (no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
