Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/2605
  
    +1. My only suggestion would be to move the deprecated keys out of the 
constructor into a separate method like `public Option<T> 
withDeprecatedKeys(String... deprecatedKeys) {`. And the same consideration if 
many of the default values are null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to