luoyuxia commented on code in PR #21668:
URL: https://github.com/apache/flink/pull/21668#discussion_r1073328257
##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveLookupJoinITCase.java:
##########
@@ -378,6 +378,31 @@ public void
testLookupJoinWithLookUpSourceProjectPushDown() throws Exception {
assertEquals("[+I[1, a], +I[2, b], +I[3, c]]", results.toString());
}
+ @Test
+ public void testLookupJoinPartitionTableWithLookUpSourceProjectPushDown()
throws Exception {
Review Comment:
Actually, this failure is not related to PartitionTable. We can just change
the test case in `testLookupJoinWithLookUpSourceProjectPushDown` to
```
TableImpl flinkTable =
(TableImpl)
tableEnv.sqlQuery(
"select b.x, b.z from "
+ "
default_catalog.default_database.probe as p "
+ " join bounded_table for
system_time as of p.p as b on p.x=b.x");
```
to reproduce it.
So, I think we can just remove the test
`testLookupJoinPartitionTableWithLookUpSourceProjectPushDown`
and only modify the test case in
`testLookupJoinWithLookUpSourceProjectPushDown`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
