zentol commented on code in PR #21691:
URL: https://github.com/apache/flink/pull/21691#discussion_r1073562660
##########
flink-tests/src/test/java/org/apache/flink/test/runtime/IPv6HostnamesITCase.java:
##########
@@ -146,15 +145,13 @@ private Inet6Address getLocalIPv6Address() {
// test whether Akka's netty can bind to the
address
log.info("Testing whether Akka can use " + addr);
- try (NetUtils.Port port =
NetUtils.getAvailablePort()) {
- final RpcService rpcService =
- RpcSystem.load()
- .localServiceBuilder(new
Configuration())
-
.withBindAddress(addr.getHostAddress())
- .withBindPort(port.getPort())
- .createAndStart();
- rpcService.closeAsync().get();
- }
+ final RpcService rpcService =
+ RpcSystem.load()
+ .localServiceBuilder(new
Configuration())
+
.withBindAddress(addr.getHostAddress())
+ .withBindPort(0)
Review Comment:
IIRC local akka rpc services don't bind to a port at all and can only be
accessed directly in the JVM.
That should mean that this test is broken since it never hits the network
layer. I'll file a separate ticket for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
