mas-chen commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1080844703
##########
flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java:
##########
@@ -82,15 +86,27 @@ private static Configuration getConfiguration() {
return flinkConfig;
}
- @Rule
Review Comment:
@zentol @MartijnVisser hope you enjoyed your break! Do you have to time to
revisit this discussion^?
It's been a while so just reminding--this is a e2e test that was previously
@Ignore'ed and you left a comment to try and re-enable it since the commented
JIRA ticket that was blocking this test was fixed. It's possible to support
this with some improvements of the Flink testcontainer framework (I can go into
the details of what is required). But I think the E2E test is redundant as per
my earlier comment on Dec 15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
