dawidwys commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1081541284
##########
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/ScalaEnumSerializerSnapshot.scala:
##########
@@ -80,25 +80,26 @@ class ScalaEnumSerializerSnapshot[E <: Enumeration] extends
TypeSerializerSnapsh
new EnumValueSerializer(enumObject)
}
- override def resolveSchemaCompatibility(
- newSerializer: TypeSerializer[E#Value]):
TypeSerializerSchemaCompatibility[E#Value] = {
+ override def resolveSchemaCompatibility(oldSerializerSnapshot:
TypeSerializerSnapshot[E#Value])
+ : TypeSerializerSchemaCompatibility[E#Value] = {
Preconditions.checkState(enumClass != null)
- Preconditions.checkState(previousEnumConstants != null)
+ Preconditions.checkState(enumConstants != null)
- if (!newSerializer.isInstanceOf[EnumValueSerializer[E]]) {
+ if (!oldSerializerSnapshot.isInstanceOf[ScalaEnumSerializerSnapshot[E]]) {
return TypeSerializerSchemaCompatibility.incompatible()
}
- val newEnumSerializer = newSerializer.asInstanceOf[EnumValueSerializer[E]]
- if (!enumClass.equals(newEnumSerializer.enum.getClass)) {
+ val oldEnumSerializerSnapshot =
+ oldSerializerSnapshot.asInstanceOf[ScalaEnumSerializerSnapshot[E]]
+ if (!enumClass.equals(oldEnumSerializerSnapshot.enumClass)) {
return TypeSerializerSchemaCompatibility.incompatible()
}
- for ((previousEnumName, index) <- previousEnumConstants) {
+ for ((enumName, index) <- oldEnumSerializerSnapshot.enumConstants) {
try {
- val newEnumName = newEnumSerializer.enum(index).toString
- if (previousEnumName != newEnumName) {
+ val oldEnumName = enumConstants(index)._1
Review Comment:
```suggestion
val enumName = enumConstants(index)._1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
