[GitHub] [flink] fsk119 commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

[GitBox]

fsk119 commented on code in PR #21717:
URL: https://github.com/apache/flink/pull/21717#discussion_r1082055861


##########
flink-table/flink-sql-client/src/test/resources/sql/table.q:
##########
@@ -79,7 +79,10 @@ show tables;
 
 # test SHOW CREATE TABLE
 show create table orders;
-CREATE TABLE `default_catalog`.`default_database`.`orders` (
++-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Review Comment:
   In the FLIP, we do reach an agreement about the presentation. BTW, I think 
it's the first version of the presentation when the input line is too long. 
From my experience, we should support printing the results with multiple lines.
   
   
![image](https://user-images.githubusercontent.com/33114724/213604189-eb68b4fe-f4a1-4b92-b429-e2edaa289657.png)
   
   In PG/Presto, the client uses '+' to indicate the current line is part of 
the last line. Considering the current change is so large, I think we can move 
the improvements to the future.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org