dawidwys commented on code in PR #20151:
URL: https://github.com/apache/flink/pull/20151#discussion_r1082525394
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java:
##########
@@ -280,4 +280,13 @@ public class ExecutionCheckpointingOptions {
.booleanType()
.defaultValue(false)
.withDescription("Flag to enable approximate local
recovery.");
+
+ public static final ConfigOption<Integer>
CHANNEL_STATE_NUMBER_OF_SUBTASKS_SHARE_FILE =
+
ConfigOptions.key("execution.checkpointing.channel-state.number-of-subtasks-share-file")
+ .intType()
+ .defaultValue(5)
+ .withDescription(
+ "Defines the maximum number of subtasks that share
the same channel state file. "
+ + "It can reduce the number of small files
when enable unaligned checkpoint. "
+ + "Each subtask will create a new channel
state file when this is configured to 1.");
Review Comment:
1. Does it apply to unaligned checkpoints only? If so, could we put it under
`unaligned` subgroup? `execution.checkpointing.unaligned.(...)`
2. Do we plan to have more options under `channel-state`? If not, I would
not introduce this subgroup.
3. I like @pnowojski idea more, but I'd add `max` prefix:
`max-subtasks-per-file`
Depending on 2. I'd go with either `channel-state.max-subtasks-per-file` or
` max-subtasks-per-channel-state-file`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
