RyanSkraba opened a new pull request, #2:
URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/2

   ## What is the purpose of the change
   
   * Originally from PR https://github.com/apache/flink/pull/15152, then 
https://github.com/apache/flink/pull/18823 to help finish the PR  for a new 
Pub/Sub connector that implements the Source API from FLIP-27
   
   ## Brief change log
   
   - Rebased https://github.com/apache/flink/pull/15152 on `master` and fixed 
conflicts
     - Squashed the original changes (retaining @jakob-ed's authorship)
     - Moved new classes to packages that align with the FLIP-27 KafkaSource
   - Modified the E2E tests to fetch a bounded number of records from the 
Pub/Sub emulator
   - Rebased https://github.com/apache/flink/pull/18823 on externalized 
repository `main`, re-homing the change to the new directory structure.
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the 
conventions defined in our code quality guide: 
https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   This change added tests and can be verified as follows:
   - Adds end-to-end test using the Pub/Sub emulator.
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads 
(100MB)*
     - *Extended integration test for recovery after master (JobManager) 
failure*
     - *Added test that validates that TaskInfo is transferred only once across 
recoveries*
     - *Manually verified the change by running a 4 node cluser with 2 
JobManagers and 4 TaskManagers, a stateful streaming program, and killing one 
JobManager and two TaskManagers during the execution, verifying that recovery 
happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs / JavaDocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to