pavel-hp commented on code in PR #52:
URL: https://github.com/apache/flink-training/pull/52#discussion_r1088675543
##########
long-ride-alerts/src/main/java/org/apache/flink/training/exercises/longrides/LongRidesExercise.java:
##########
@@ -97,18 +99,61 @@ public static void main(String[] args) throws Exception {
@VisibleForTesting
public static class AlertFunction extends KeyedProcessFunction<Long,
TaxiRide, Long> {
-
+ private ValueState<TaxiRide> rideState;
Review Comment:
Since this class implement `Serializable` interface
It has to be `transient`
` private transient ValueState<TaxiRide> rideState;`
Also I recommend to specify
`serialVersionUID`
private static final long serialVersionUID = 1L;
##########
rides-and-fares/src/main/java/org/apache/flink/training/exercises/ridesandfares/RidesAndFaresExercise.java:
##########
@@ -98,20 +100,39 @@ public static void main(String[] args) throws Exception {
public static class EnrichmentFunction
extends RichCoFlatMapFunction<TaxiRide, TaxiFare, RideAndFare> {
+ private ValueState<TaxiRide> rideState;
Review Comment:
Since this class implement Serializable interface
It has to be transient
Also I recommend to specify
serialVersionUID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
