[
https://issues.apache.org/jira/browse/FLINK-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557348#comment-15557348
]
ASF GitHub Bot commented on FLINK-4738:
---------------------------------------
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2594#discussion_r82496888
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -507,12 +509,18 @@ public void suspendJob(final Throwable cause) {
* @return Acknowledge the task execution state update
*/
@RpcMethod
- public boolean updateTaskExecutionState(final TaskExecutionState
taskExecutionState) {
+ public Acknowledge updateTaskExecutionState(final TaskExecutionState
taskExecutionState) throws ExecutionGraphException {
if (taskExecutionState == null) {
- return false;
+ throw new NullPointerException("TaskExecutionState must
not be null.");
+ }
+
+ if (executionGraph.updateState(taskExecutionState)) {
+ return Acknowledge.get();
} else {
- return executionGraph.updateState(taskExecutionState);
+ throw new ExecutionGraphException("The execution
attempt " +
--- End diff --
Execution attempt not exists is one of the failure causes, maybe we can
move the throw behavior into the function call updateState, and let the
function decide which exception should be thrown
> Port TaskManager logic to TaskExecutor
> --------------------------------------
>
> Key: FLINK-4738
> URL: https://issues.apache.org/jira/browse/FLINK-4738
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> Port the basic operations of the {{TaskManager}} to the {{TaskExecutor}}.
> These operations include the task lifecycle methods, {{JobManager}}
> association logic and setup of TaskManager components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
