masteryhx commented on PR #21679: URL: https://github.com/apache/flink/pull/21679#issuecomment-1407299580
Thanks for the pr. It's a bit strange that add close flag in StateChangelogHandleStreamHandleReader. I'd like to suggest to add this flag in the stream of ChangelogStreamHandleReaderWithCache: 1. IIUC, Upon restart, Only ChangelogStreamHandleReaderWithCache will be global, but StateChangelogHandleStreamHandleReader will always be used as a new object so that current flag will not be reused and will always be false ? 2. It's better to put the responsbility of "close once" into the smallest scope who relys on it. Or maybe I missed something ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
