zhuzhurk commented on code in PR #21743:
URL: https://github.com/apache/flink/pull/21743#discussion_r1089677545


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/ConsumerVertexGroup.java:
##########
@@ -66,4 +75,12 @@ public boolean isEmpty() {
     public ExecutionVertexID getFirst() {
         return iterator().next();
     }
+
+    public ConsumedPartitionGroup getConsumedPartitionGroup() {
+        return checkNotNull(consumedPartitionGroup, "ConsumedPartitionGroup is 
not properly set.");
+    }
+
+    public void setConsumedPartitionGroup(ConsumedPartitionGroup 
consumedPartitionGroup) {

Review Comment:
   `this.consumedPartitionGroup == null` is good enough I think. We do not 
expect this set method of one group to be invoked multiple times.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to