afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1407709550
@MartijnVisser unfortunately CI did not capture all failures caused by our
strict checks for deprecated APIs in `flink-examples` at once.
Now that the original sources listed in
[FLINK-28227](https://issues.apache.org/jira/browse/FLINK-28227) ([Azure Build
1](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=37208&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=14044))
got fixed, it started failing on two more sources from `flink-examples-table`:
[Azure Build
2](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=45333&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=16395).
Unfortunately, we are missing an integration layer between the new
`DataGeneratorSource` and the Table API needed in order to make it work. For
instance, `SocketSourceFunction` has to be rewritten as a `GeneratorFunction`,
however, we, by design, do not have access to `RuntimeContext` that is required
to initialize the serialization schema in the original implementation:
https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/connectors/SocketSourceFunction.java#L36-L39
https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/connectors/SocketSourceFunction.java#L72-L74
This requires a larger effort and won't realistically happen until the
release branch cut unless someone who works closely with Table API could take a
look.
Another alternative is to disable the strict policy for using deprecated
APIs in `flink-examples-table`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
