luoyuxia commented on PR #21698: URL: https://github.com/apache/flink/pull/21698#issuecomment-1407946635
> @luoyuxia thanks for your update! I have a minor comment for the test splitting: although there is no strict guideline on how to classify various sql commands, it is clearly inappropriate to classify commands such as show, load, use, etc. into ddl or dml, should we adjust it to refer to mysql's definition of ddl, dml, and put the remaining into sqlOtherOperation (probably called sqlCommand is also easy to cause ambiguity). Agree to it. The reason I put `show`/`use` into ddl is from the Hive's [language manual ddl wiki](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Show). But now, I think the hive's is not correct and suitable for all systems. So i like the idea that put them into `sqlOtherOperation`. > Btw, since 'begin statement set' is used to assist multiple dml statements, we can also put it into dml test, WDYT? Agree to it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
